Conversation
Explicit PR finish already delegates merge to GitHub, so creating a local __integrate-* helper worktree just to fall back into the PR path adds Source Control noise without improving safety. The finish script now keeps the source-branch sync and preflight checks, but only materializes the integration helper when direct push remains possible. Constraint: main checkout must stay untouched during finish Rejected: Hide temp helper rows only in VS Code | still opens real git worktrees and preserves churn Confidence: high Scope-risk: narrow Directive: If PR mode later needs local merge simulation again, restore it with an explicit flag instead of silently reintroducing __integrate-* helpers Tested: bash -n scripts/agent-branch-finish.sh Tested: bash -n templates/scripts/agent-branch-finish.sh Tested: node --test test/finish.test.js test/metadata.test.js Tested: openspec validate agent-codex-fix-temp-helper-worktree-cleanup-2026-04-23-11-56 --type change --strict Not-tested: end-to-end gx branch finish against live GitHub checks in this run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by gx branch finish (PR flow).